Updates to change password functionality #5294
Draft
+399
−272
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
0xi4o
commented
Oct 6, 2025
0xi4o
commented
- Change password now requires old password to be filled and validated before applying new password
hob
reviewed
Oct 7, 2025
| if (!compareHash(newUserData.oldPassword, oldUserData.credential)) { | ||
| throw new InternalFlowiseError(StatusCodes.UNAUTHORIZED, UserErrorMessage.INVALID_USER_CREDENTIAL) | ||
| } | ||
| if (newUserData.newPassword !== newUserData.confirmPassword) { |
There was a problem hiding this comment.
For consistency, shouldn't this also use the compareHash() function to do the comparison?
hob
reviewed
Oct 7, 2025
| // @ts-ignore | ||
| const hash = bcrypt.hashSync(newUserData.password, salt) | ||
| if (newUserData.oldPassword && newUserData.newPassword && newUserData.confirmPassword) { | ||
| if (!oldUserData.credential) { |
There was a problem hiding this comment.
Is this because you can't change your password if you authenticated with social login? If that's the case, is there nothing more explicit on the user model that could be used to drive this condition rather than the presence or absence of a password?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.